Refactor Durable Objects WebSocket documentation #18344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshthoward
requested review from
a team,
GregBrimble,
Oxyjun,
ToriLindsay,
elithrar,
irvinebroque,
jasnell,
mikenomitch and
vy-ton
as code owners
github-actions
bot
added
size/l
product:durable-objects
Contributor
|
This PR changes current filenames or deletes current files. Make sure you have redirects set up to cover the following paths:
|
github-actions
bot
assigned
elithrar,
Oxyjun,
vy-ton,
GregBrimble,
irvinebroque,
jasnell,
mikenomitch and
ToriLindsay
Deploying cloudflare-docs with
|
| Latest commit: |
454a1ba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc6cad3a.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://joshthoward-do-websocket-ref.cloudflare-docs-7ou.pages.dev |
Contributor
Oxyjun
reviewed
Nov 22, 2024
Contributor
Oxyjun
left a comment
Oxyjun
left a comment
There was a problem hiding this comment.
Leaving some suggestions to align with the style guide.
Contributor
|
This PR deletes two WebSocket related files:
Where do we want to redirect each of these paths? We’ve only introduced one new file:
|
Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: Jun Lee <[email protected]>
Oxyjun
requested review from
a team,
KianNH,
WalshyDev and
pedrosousa
as code owners
Oxyjun
approved these changes
Nov 22, 2024
harshil1712
pushed a commit
that referenced
this pull request
Dec 3, 2024
* Fix typo * Update order and lint files * Refactor Durable Objects WebSocket documentation * Fixing bad Prettier automation in <code> blocks. * Removing <br> and using MDX syntax. * Update src/content/docs/durable-objects/api/alarms.mdx Co-authored-by: Jun Lee <[email protected]> * Apply suggestions from code review Co-authored-by: Jun Lee <[email protected]> * Fixing broken links to deleted chapters. Adding public redirect. * Fixing broken links part 2 --------- Co-authored-by: Jun Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate information on WebSockets into best practices.
Screenshots (optional)
Documentation checklist